[Modal][base] Drop component prop #37058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Netlify deploy previewhttps://deploy-preview-37058--material-ui.netlify.app/ Bundle size report |
hbjORbj
force-pushed
the
modal/component-prop
branch
from
9a924ae
to
8e41846
Compare
hbjORbj
force-pushed
the
modal/component-prop
branch
from
8e41846
to
9c640b4
Compare
hbjORbj
force-pushed
the
modal/component-prop
branch
from
ac4a911
to
c83ecea
Compare
hbjORbj
commented
Apr 28, 2023
| @@ -91,7 +90,7 @@ const Modal = React.forwardRef(function Modal<RootComponentType extends React.El | |||
| slots = {}, | |||
| ...other | |||
| } = props; | |||
|
|
|||
| const manager = managerProp as any; | |||
There was a problem hiding this comment.
This is temporary. I think there is some type error in this file. For example,
we should change
const modal = React.useRef<{
modalRef?: typeof modalRef.current;
mountNode?: typeof mountNodeRef.current;
}>({});to
const modal = React.useRef<{
mount?: Element;
modalRef?: Element;
}>({});to match the type of methods provided by ModalManager. I'd rather do these changes in a separate PR.
There was a problem hiding this comment.
Weird. But yes, I agree, let's solve this in a separate PR. Could you just add a TODO comment above this line explaining what is it for?
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #36679